View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000169 | vhffs-users | public | 2005-11-02 23:16 | 2015-02-23 08:13 | |
Reporter | jbnote | Assigned To | soda | ||
Priority | normal | Severity | block | Reproducibility | always |
Status | closed | Resolution | open | ||
Summary | 0000169: Unable to change the "reply-to" setting of the mailing-list engine | ||||
Description | You cannot unset the reply-to option of listengine mailing-lists. Looking at the code, even if you could set it off, then you could not set it on again. This is *very* important (reply-to is a religious matter, and i fear we're not of the same religion ;). Furthermore, the bug is easily fixed (see below). | ||||
Additional Information | Please search for set_replyto in http://svn.naquadah.org/filedetails.php?repname=vhffs&path=%2Ftrunk%2Fvhffs-panel%2Fmailinglist%2Fsave_options.pl&rev=0&sc=0 Then see the called ->set_replyto function in : http://svn.naquadah.org/filedetails.php?repname=vhffs&path=%2Ftrunk%2Fvhffs-api%2Fsrc%2FVhffs%2FServices%2FMailing.pm&rev=0&sc=0 The logic is broken, set_replyto is not meant to be called directly with 0 or 1 as argument. You should : - call set_replytolist instead of set_replyto( 1 ) in save_option.pl - implement an unset_replytolist() function in Mailing.pm - call unset_replytolist instead of set_replyto( 0 ) in save_option.pl This way there will be no api breakage in Mailing.pm, and the thing will work as expected. No patch, as I don't speak perl (sorry about this). Thanks for listening, JB | ||||
Tags | No tags attached. | ||||
|
New note after further investigation. the mailing-list code proper uses directly the list->reply_to as a boolean flag, see function sendmail_to_list in file [http://svn.naquadah.org/filedetails.php?repname=vhffs&path=%2Ftrunk%2Fvhffs-listengine%2Fsrc%2Flistengine.pl&rev=0&sc=0] The the wrong code is indeed in Mailing.pm, [http://svn.naquadah.org/filedetails.php?repname=vhffs&path=%2Ftrunk%2Fvhffs-api%2Fsrc%2FVhffs%2FServices%2FMailing.pm&rev=0&sc=0] where you should delete the following functions, which seem to think that the reply-to field is a mail address, which makes no real sense (the reply-to you want is always the address of the list) : Delete: sub set_replytolist { my $self; my $string = $self->{'local_part'} ."\@" . $self->{'domain'} ; return $self->set_replyto( $string ); } sub set_replyto { my( $self , $value ) = @_; return -1 if( Vhffs::Functions::valid_mail( $value ) != 1 ); $self->{'reply_to'} = $value; return 1; } Instead, you should simply write the following function : Add : sub set_replyto { my( $self , $value ) = @_; $self->{'reply_to'} = $value; } get_replyto is already allright. You should *NOT* modify the save_options.pl file. JB |
|
This bug is now resolved in the current version in subversion. There is an API breakage, but the API can broke while there is no release anymore. Regards, |
Date Modified | Username | Field | Change |
---|---|---|---|
2005-11-02 23:16 | jbnote | New Issue | |
2005-11-02 23:47 | jbnote | Note Added: 0000274 | |
2005-11-16 20:14 | soda | Status | new => assigned |
2005-11-16 20:14 | soda | Assigned To | => soda |
2006-04-18 22:38 | soda | Note Added: 0000282 | |
2006-04-18 22:38 | soda | Status | assigned => resolved |
2015-02-23 08:13 | gradator | Status | resolved => closed |